On Tue, Oct 26, 2021 at 07:31:43PM +0200, Maciej Machnikowski wrote: > +/* SyncE section */ > + > +enum if_eec_state { > + IF_EEC_STATE_INVALID = 0, > + IF_EEC_STATE_FREERUN, > + IF_EEC_STATE_LOCKED, > + IF_EEC_STATE_LOCKED_HO_ACQ, Is this referring to "Locked mode, acquiring holdover: This is a temporary mode, when coming from free-run, to acquire holdover memory." ? It seems ice isn't using it, so maybe drop it? Can be added later in case we have a driver that can report it There is also "Locked mode, holdover acquired: This is a steady state mode, entered when holdover memory is acquired." But I assume that's "IF_EEC_STATE_LOCKED" > + IF_EEC_STATE_HOLDOVER, > +};