On Tue, Oct 26, 2021 at 2:44 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Tue, 26 Oct 2021 07:28:39 -0700 > Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote: > > > > If this update has any meaning, please make a separate patch for this part. > > > > Hi Masami, > > > > Thanks for the feedback. The above change is to ensure we remove > > triggers in the reverse order that we created them - important when > > one trigger depends on another. I can split it out into a separate > > patch and will add a README pattern check to the requires tag for > > these tests. > > Also make sure to run all the ftracetests. When I ran it with this update, > most of the other histogram tests failed. Even with your patches applied to > the running kernel. Hi Steve, On my setup I without any of the changes applied (config hist triggers enabled): ./ftracetests # of passed: 41 # of failed: 40 # of unresolved: 0 # of untested: 0 # of unsupported: 32 # of xfailed: 0 # of undefined(test bug): 0 Do all the tests pass for you, before any of the changes in this series? Maybe some of the tests need updating? - Kalesh > > -- Steve