On Wed, Sep 29, 2021 at 10:26:49AM -0600, Shuah Khan wrote: > On 9/29/21 9:35 AM, Will Deacon wrote: > > On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote: > > > I'm not sure it's a particularly good idea to run kselftest as a > > > non-root user TBH, it's going to cause you to skip a lot of tests. > We don't want Kselftest default run to be as root. Users can choose to > run as root which would be an explicit choice so they expect and plan > for the impact. Example panic test. OTOH if you're trying to verify that the tests aren't broken it's not that great since it'll mean that you'll not be exercising a bunch of the code. > > Ah, thanks for pointing that out. It would probably be better to skip the > > tests rather than fail them if they're not running with sufficient > > permissions, but I'll go ahead and queue your v3 for now. > Correct. I would like to see tests skipped not failed if either config > or permissions are lacking to run the tests. As I said previously that's what my v3 that Will referenced above does.
Attachment:
signature.asc
Description: PGP signature
