On Tue, Aug 24, 2021 at 3:24 PM Ido Schimmel <idosch@xxxxxxxxxx> wrote: > > On Mon, Aug 23, 2021 at 04:58:54PM +0800, Po-Hsu Lin wrote: > > There are several test cases in the net directory are still using > > exit 0 or exit 1 when they need to be skipped. Use kselftest > > framework skip code instead so it can help us to distinguish the > > return status. > > > > Criterion to filter out what should be fixed in net directory: > > grep -r "exit [01]" -B1 | grep -i skip > > > > This change might cause some false-positives if people are running > > these test scripts directly and only checking their return codes, > > which will change from 0 to 4. However I think the impact should be > > small as most of our scripts here are already using this skip code. > > And there will be no such issue if running them with the kselftest > > framework. > > > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx> > > Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx> > Tested-by: Ido Schimmel <idosch@xxxxxxxxxx> Thank you for the test and the review! PHLin
