Re: [PATCH v2] kunit: tool: allow filtering test cases via glob

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 36a21d51725af2ce0700c6ebcb6b9594aac658a6]

url:    https://github.com/0day-ci/linux/commits/Daniel-Latypov/kunit-tool-allow-filtering-test-cases-via-glob/20210810-063638
base:   36a21d51725af2ce0700c6ebcb6b9594aac658a6
config: arc-randconfig-r012-20210809 (attached as .config)
compiler: arceb-elf-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/7916753f125a2e310f8ff63e04dbf57931c0482e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Latypov/kunit-tool-allow-filtering-test-cases-via-glob/20210810-063638
        git checkout 7916753f125a2e310f8ff63e04dbf57931c0482e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from lib/kunit/executor.c:225:
>> lib/kunit/executor_test.c:18:6: warning: no previous prototype for 'dummy_test' [-Wmissing-prototypes]
      18 | void dummy_test(struct kunit *test) {}
         |      ^~~~~~~~~~


vim +/dummy_test +18 lib/kunit/executor_test.c

    10	
    11	static void kfree_at_end(struct kunit *test, const void *to_free);
    12	static void free_subsuite_at_end(struct kunit *test,
    13					 struct kunit_suite *const *to_free);
    14	static struct kunit_suite *alloc_fake_suite(struct kunit *test,
    15						    const char *suite_name,
    16						    struct kunit_case *test_cases);
    17	
  > 18	void dummy_test(struct kunit *test) {}
    19	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux