On Fri, Aug 06, 2021 at 06:15:29PM -0700, Vinicius Costa Gomes wrote:
> > int ptp_clock_unregister(struct ptp_clock *ptp)
> > {
> > + if (ptp_vclock_in_use(ptp)) {
> > + pr_err("ptp: virtual clock in use\n");
> > + return -EBUSY;
> > + }
> > +
>
> None of the drivers (that I looked) expect ptp_clock_unregister() to
> return an error.
>
> So, what should we do?
> 1. Fix all the drivers to return an error on module unloading (that's
> usually the path ptp_clock_unregister() is called)?
> 2. Remove all the PTP virtual clocks when the physical clock is
> unregistered?
This:
3. Let the vclocks hold a reference to the underlying posix dynamic clock.
Thanks,
Richard
