On Wed, Jul 28, 2021 at 05:29:53PM +0100, Mark Brown wrote: > On Wed, Jul 28, 2021 at 02:44:07PM +0100, Dave Martin wrote: > > > This might be a bit clearer if the setup code was clearly separate from > > the tests, but so long as the ordering requirements are clearly > > documented that seems reasonably OK. > > We can't really split the setup code out since the setup code would have > to rely on one of the ABIs we're trying to test which is all fine and > good until the tests actually help us catch something, we have to build > up knowledge of the values as we go and hope that the cross checking we > end up with helps us at least catch inconsistencies. Ack. The setup code could be defensive, but you would in effect be doing some of the tests twice then. Or the fact that the setup code is "separate" from the tests might be a bit of an illusion. Cheers ---Dave
