On 7/22/21 3:19 PM, Luis Chamberlain wrote: > + * The real value to try_module_get() is the module_is_live() check which > + * ensures this the caller of try_module_get() can yields to userspace module > + * removal requests and fail whatever it was about to process. can yields -> can yield? Otherwise this looks really well written to me. Bart.