On Sat, Jul 17, 2021 at 4:48 PM André Almeida <andrealmeid@xxxxxxxxxxxxx> wrote: > > Remove custom functions for testing and use KUnit framework. Keep the > tested functions and test data the same. > > Current test threat (g/u)uid_parse and (g/u)uid_equal as different test > cases. Make both functions being part of the same test case, given the > dependency regarding their results. This reduces the tests cases from 6 > cases to 4, while keeping the test coverage the same. Given that we have > 3 strings for each test case, current test output notifies 18 tests > results, and the KUnit output announces 12 results. > > Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxxxxx> > Reviewed-by: Daniel Latypov <dlatypov@xxxxxxxxxx> I don't think I have anything to add that hasn't already been said. Nevertheless, this looks good to me. Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
