On Tue, Jul 06, 2021 at 12:09:44PM +0200, Geert Uytterhoeven wrote:
> All but one symbols that select RATIONAL are tristate, but RATIONAL
> itself is bool. Change it to tristate, so the rational fractions
> support code can be modular if no builtin code relies on it.
Works for me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> Exposed by commit b6c75c4afceb8bc0 ("lib/math/rational: add Kunit test
> cases") and CONFIG_KUNIT_ALL_TESTS=m.
>
> v2:
> - Drop compile-testing and help text.
> ---
> lib/math/Kconfig | 2 +-
> lib/math/rational.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/math/Kconfig b/lib/math/Kconfig
> index f19bc9734fa7cc4b..0634b428d0cb7f86 100644
> --- a/lib/math/Kconfig
> +++ b/lib/math/Kconfig
> @@ -14,4 +14,4 @@ config PRIME_NUMBERS
> If unsure, say N.
>
> config RATIONAL
> - bool
> + tristate
> diff --git a/lib/math/rational.c b/lib/math/rational.c
> index c0ab51d8fbb98d17..ec59d426ea638b0f 100644
> --- a/lib/math/rational.c
> +++ b/lib/math/rational.c
> @@ -13,6 +13,7 @@
> #include <linux/export.h>
> #include <linux/minmax.h>
> #include <linux/limits.h>
> +#include <linux/module.h>
>
> /*
> * calculate best rational approximation for a given fraction
> @@ -106,3 +107,5 @@ void rational_best_approximation(
> }
>
> EXPORT_SYMBOL(rational_best_approximation);
> +
> +MODULE_LICENSE("GPL v2");
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
