On 2021/7/2 16:30, Michael S. Tsirkin wrote: > On Fri, Jul 02, 2021 at 04:17:17PM +0800, Yunsheng Lin wrote: >>> Let's reuse ptr_ring.c in tools/virtio/ringtest. Nothing virt specific there. >> >> It *does* have some virtio specific at the end of ptr_ring.c. >> It can be argued that the ptr_ring.c in tools/virtio/ringtest >> could be refactored to remove the function related to virtio. >> >> But as mentioned in the previous disscusion [1], the tools/virtio/ >> seems to have compile error in the latest kernel, it does not seems >> right to reuse that. >> And most of testcase in tools/virtio/ seems >> better be in tools/virtio/ringtest instead，so until the testcase >> in tools/virtio/ is compile-error-free and moved to tools/testing/ >> selftests/, it seems better not to reuse it for now. > > > That's a great reason to reuse - so tools/virtio/ stays working. > Please just fix that. I understand that you guys like to see a working testcase of virtio. I would love to do that if I have the time and knowledge of virtio, But I do not think I have the time and I am familiar enough with virtio to fix that now. >
