Re: [PATCH 0/3] Restore extra_mem_pages and add slot0_mem_pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09.06.2021 01:38, Zhenzhong Duan wrote:
(39fe2fc96694 "selftests: kvm: make allocation of extra memory take effect")
changed the meaning of extra_mem_pages and treated it as slot0 memory size.

In fact extra_mem_pages is used for non-slot0 memory size, there is no custom
slot0 memory size support. See discuss in https://urldefense.com/v3/__https://lkml.org/lkml/2021/6/3/551__;!!GqivPVa7Brio!K2FcwkE2nzlPAWgBHh6o6jtaWe66RMlfkb-b_8mAtVa5d8ez_sArupY-EqIquuCj2sorww$
for more details.

This patchset restores extra_mem_pages's original meaning and adds support for
custom slot0 memory with a new parameter slot0_mem_pages.

Run below command, all 39 tests passed.
# make -C tools/testing/selftests/ TARGETS=kvm run_tests

Zhenzhong Duan (3):
   Revert "selftests: kvm: make allocation of extra memory take effect"
   Revert "selftests: kvm: fix overlapping addresses in
     memslot_perf_test"
   selftests: kvm: Add support for customized slot0 memory size

  .../testing/selftests/kvm/include/kvm_util.h  |  7 +--
  .../selftests/kvm/kvm_page_table_test.c       |  2 +-
  tools/testing/selftests/kvm/lib/kvm_util.c    | 47 +++++++++++++++----
  .../selftests/kvm/lib/perf_test_util.c        |  2 +-
  .../testing/selftests/kvm/memslot_perf_test.c |  2 +-
  5 files changed, 45 insertions(+), 15 deletions(-)


Looks good to me, thanks!

For the whole series:
Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@xxxxxxxxxx>

BTW: It looks like there was something wrong with the clock (or time zone
setup) of the machine this series was posted from since the "Date:"
headers on these four messages say they were sent Jun 8, 23:38 UTC
(while the time right now is Jun 8, 16:45 UTC).

Maciej



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux