Às 21:54 de 05/06/21, David Gow escreveu: > On Sun, Jun 6, 2021 at 5:52 AM André Almeida <andrealmeid@xxxxxxxxxxxxx> wrote: >> >> Remove custom functions for testing and use KUnit framework. Test cases >> and test data remains the same. >> >> Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxxxxx> >> --- > > Thanks! It's always exciting to see more tests using KUnit. > > Note that the names here (filename, suite name, and Kconfig entry > name) don't match what we usually recommend for KUnit tests: > https://www.kernel.org/doc/html/latest/dev-tools/kunit/style.html > > Given that this is an existing test, it is definitely okay to keep the > old names if you think it'd break something, but if there's no issue > it may be worth renaming them. The test suite name (which is new > anyway) ideally shouldn't end in "-test": just "uuid" is best. > > I know there are quite a few existing tests which don't adhere to > these perfectly yet, but ideally new ones will if it's convenient. > > Otherwise, this looks great. I've run it here, and it worked well and > picked up on any deliberate errors I introduced. > > So this is > Tested-by: David Gow <davidgow@xxxxxxxxxx> Thank you for the feedback :) I'll submit a v2 applying your suggestions. > > Cheers, > -- David >
