On Mon, May 17, 2021 at 8:58 PM David Gow <davidgow@xxxxxxxxxx> wrote: > > Make the default .kunitconfig (specified in > arch/um/configs/kunit_defconfig) specify CONFIG_KUNIT_ALL_TESTS by > default. KUNIT_ALL_TESTS runs all tests which have satisfied > dependencies in the current .config (which would be the architecture > defconfig). > > Currently, the default .kunitconfig enables only the example tests and > KUnit's own tests. While this does provide a good example of what a > .kunitconfig for running a few individual tests should look like, it > does mean that kunit_tool runs a pretty paltry collection of tests by > default. > > A default run of ./tools/testing/kunit/kunit.py run now runs 70 tests > instead of 14. > > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> I am totally on board with what you want to do here, but I have one minor issue below. Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > --- > arch/um/configs/kunit_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/um/configs/kunit_defconfig b/arch/um/configs/kunit_defconfig > index 9235b7d42d38..becf3432a375 100644 > --- a/arch/um/configs/kunit_defconfig > +++ b/arch/um/configs/kunit_defconfig Could we also apply this to tools/testing/kunit/configs/all_tests.config ? The contents of the file are identical, and I think are supposed to be for the same purpose. > @@ -1,3 +1,2 @@ > CONFIG_KUNIT=y > -CONFIG_KUNIT_TEST=y > -CONFIG_KUNIT_EXAMPLE_TEST=y > +CONFIG_KUNIT_ALL_TESTS=y > -- > 2.31.1.751.gd2f1c929bd-goog >
