On Thu, Apr 08, 2021 at 04:43:19PM -0700, Axel Rasmussen wrote: > Minimizing header file inclusion is desirable. In this case, we can do > so just by forward declaring the enumeration our signature relies upon. > > Signed-off-by: Axel Rasmussen <axelrasmussen@xxxxxxxxxx> > --- > include/linux/hugetlb.h | 5 ++++- > mm/hugetlb.c | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 1d3246b31a41..dfb749eaf348 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -11,7 +11,6 @@ > #include <linux/kref.h> > #include <linux/pgtable.h> > #include <linux/gfp.h> > -#include <linux/userfaultfd_k.h> > > struct ctl_table; > struct user_struct; > @@ -136,6 +135,8 @@ unsigned long hugetlb_total_pages(void); > vm_fault_t hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, > unsigned long address, unsigned int flags); > #ifdef CONFIG_USERFAULTFD > +enum mcopy_atomic_mode; (I'm not 100% sure, but.. maybe this can be moved even out of ifdef? Then you can define it once at the top rather than twice?) Reviewed-by: Peter Xu <peterx@xxxxxxxxxx> -- Peter Xu
