Hi Pratik, On Thu, Apr 1, 2021 at 4:45 AM Pratik Rajesh Sampat <psampat@xxxxxxxxxxxxx> wrote: > ... > To run this test specifically: > $ make -C tools/testing/selftests TARGETS="cpuidle" run_tests I have not become any smarter than I was with version 1, and still assumed that the "$" meant regular user. Please put it as "#" or separate the two steps, compile and run. > > There are a few optinal arguments too that the script can take optional Suggest to also specifically mention how to run without re-compile, # ./cpuidle.sh -v Note also that the test still leaves all idle states disabled when done. > [-h <help>] > [-i <run timer tests>] > [-m <location of the module>] > [-o <location of the output>] > [-v <verbose> (run on all cpus)] > Default Output location in: tools/testing/selftest/cpuidle/cpuidle.log ... > +cpu_is_online() > +{ > + cpu=$1 > + if [ ! -f "/sys/devices/system/cpu/cpu$cpu/online" ]; then > + echo 0 incorrect. should be: > + echo 1 ... Doug