Hi, Babu, On Fri, Mar 12, 2021 at 01:09:50PM -0600, Babu Moger wrote: > > - if (strcmp(resctrl_val, "mba") == 0) > > + if (!strncmp(resctrl_val, MBA_STR, sizeof(MBA_STR))) > > sprintf(schema, "%s%d%c%s", "MB:", resource_id, '=', > > schemata); > I see there are few other references as well. Like this. > > 1 cat_test.c cat_perf_miss_val 135 if > (!validate_resctrl_feature_request("cat")) > > 2 cqm_test.c cqm_resctrl_val 125 if > (!validate_resctrl_feature_request("cqm")) > > 3 mba_test.c mba_schemata_change 157 if > (!validate_resctrl_feature_request("mba")) > > 4 mbm_test.c mbm_bw_change 131 if > (!validate_resctrl_feature_request("mbm")) > > Should you use CAT_STR and CQM_STR etc.. in here as well? Sure. I will fix this. Thanks. -Fenghua