On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote: > Did you change anything other than fixing the Signed-off-by that Shuah > requested? No, I only fixed the Signed-off-by warning. > Generally when you make a small change after receiving a Reviewed-by > (especially one so small as here), you are supposed to include the > Reviewed-by with the other git commit message footers directly below > the "Signed-off-by". Please remember to do so in the future. > > Also, when you make a change to a patch and send out a subsequent > revision, it is best practice to make note explaining the changes you > made since the last revision in the "comment section" [1] of the > git-diff, right after the three dashes and before the change log as > you can see in this example [2] (note that everything after > "Signed-off-by: David Gow <davidgow@xxxxxxxxxx>\n ---" and before > "tools/testing/kunit/configs/broken_on_uml.config | 2 ++" is discarded > by git am). Sorry for the incovenience regarding best practices, I'll keep that noted for further contributions.
