On Mon, Feb 08, 2021 at 11:16:41AM +0100, Andrew Jones wrote: > > diff --git a/tools/testing/selftests/kvm/lib/rbtree.c b/tools/testing/selftests/kvm/lib/rbtree.c > > new file mode 100644 > > index 000000000000..a703f0194ea3 > > --- /dev/null > > +++ b/tools/testing/selftests/kvm/lib/rbtree.c > > @@ -0,0 +1 @@ > > +#include "../../../../lib/rbtree.c" > > > > We shouldn't dip into kernel code like this. We can use tools/lib/rbtree.c > though. > > Besides the rbtree.c thing, Oops, sorry, just realized the first '..' applies to kvm's lib subdir. So this is already using tools/lib/rbtree.c Thanks, drew > > Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx>
