On Mon, Jan 11, 2021 at 10:43:17AM +0000, Richard Fitzgerald wrote: > On 11/01/2021 10:39, Richard Fitzgerald wrote: > > On 11/01/2021 10:36, Andy Shevchenko wrote: > > > On Mon, Jan 11, 2021 at 12:28 PM Petr Mladek <pmladek@xxxxxxxx> wrote: > > > > > > > > Sigh, I have just realized that Andy and Rasmus, the other > > > > vsprintf maintainers and reviewers, were not in CC. > > > > I am sorry for not noticing this earlier. > > > > > > > > The patchset is ready for 5.12 from my POV. > > > > > > Thanks, Petr! > > > > > > I have one question, do we have a test case for that? If not, I prefer > > > defer until a test case will be provided. > > > > > > > See patch 3, numbers_prefix_overflow() > > Sorry, I missed you off the original mailing so you won't have > seen the other patches. > Patch 3 with the test cases is here: > https://lore.kernel.org/lkml/X%2FwnoJLEt0zQskDU@alley/T/#mf2ffba20126e438bea7af171bc78fdbebdb40027 Good, you did it! Couple of remarks: - free resources in the same function where you allocated them - use post increment where it doesn't matter (like total_test) -- With Best Regards, Andy Shevchenko
