Re: [PATCH] selftests/vm: Fix building protection keys test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 14 Dec 2020 22:09:51 +0530 Harish <harish@xxxxxxxxxxxxx> wrote:

> The previous patch

d8cbe8bfa7d ("tools/testing/selftests/vm: fix build error"), yes?

> tries to include a arch check for powerpc using
> findstring, which prevents test from building on powerpc arch.

Why is that?  Please describe the error fully.  Presumably by pasting
the error messages?

> Fix
> this with filtering using machine type.

How does this fix whatever-the-problem-was?

Presumably the 5.10 build fails under some circumstances, yes?  In
which case a Fixes: line and a cc:stable@xxxxxxxxxxxxxxx are needed.

> Signed-off-by: Harish <harish@xxxxxxxxxxxxx>
> ---
>  tools/testing/selftests/vm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> index 691893afc15d..0dc632cdbc73 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -61,7 +61,7 @@ TEST_GEN_FILES += $(BINARIES_64)
>  endif
>  else
>  
> -ifneq (,$(findstring $(ARCH),powerpc))
> +ifneq (,$(filter $(MACHINE),ppc64 ppc64le))
>  TEST_GEN_FILES += protection_keys
>  endif
>  
> -- 
> 2.26.2



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux