On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote: > > The use of manual open() and .close() calls seems to be an attempt to > keep the contents in scope. > But Python doesn't restrict variables like that, so we can introduce new > variables inside of a `with` and use them outside. > > Do so to make the code more Pythonic. > > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx> > --- I'm fine with this, and it clearly works fine for me. Out of curiosity, though, is there any difference here other than it being more usual Python style? We've struggled a bit in the past toeing a line between trying to follow "normal" Python style versus adapting it a bit to be more "kernel-y". Experience thus far has actually been that going out on our own has caused more problems than it solves, so I'm all for this change, but I do admit that my brain does understand the older code a touch more easily. In any case, Reviewed-by: David Gow <davidgow@xxxxxxxxxx> -- David
