Re: [net-next v3 5/8] seg6: add support for the SRv6 End.DT4 behavior

[Jakub Kicinski <kuba@xxxxxxxxxx>]

On Mon, 23 Nov 2020 19:28:53 +0100 Andrea Mayer wrote:
> +static int cmp_nla_vrftable(struct seg6_local_lwt *a, struct seg6_local_lwt *b)
> +{
> +	struct seg6_end_dt_info *info_a = seg6_possible_end_dt_info(a);
> +	struct seg6_end_dt_info *info_b = seg6_possible_end_dt_info(b);
> +
> +	if (IS_ERR(info_a) || IS_ERR(info_b))
> +		return 1;

Isn't this impossible? I thought cmp() can only be called on fully
created lwtunnels and if !CONFIG_NET_L3_MASTER_DEV the tunnel won't 
be created?

> +	if (info_a->vrf_table != info_b->vrf_table)
> +		return 1;
> +
> +	return 0;