On Sun, Nov 22, 2020 at 5:45 AM Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > Our goal is to always enable __must_check where appreciate, so this > > CONFIG option is no longer needed. > > This would be great. It also implies we can then move it to > `compiler_attributes.h` since it does not depend on config options > anymore. > > We should also rename it to `__nodiscard`, since that is the > standardized name (coming soon to C2x and in C++ for years). > > Cc'ing the Clang folks too to make them aware. > I can move it to compiler_attribute.h This attribute is supported by gcc, clang, and icc. https://godbolt.org/z/ehd6so I can send v2. I do not mind renaming, but it should be done in a separate patch. -- Best Regards Masahiro Yamada
