On Thu, Nov 12, 2020 at 07:10:25PM -0800, Andrew Morton wrote: > On Thu, 12 Nov 2020 20:07:32 +0200 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > Test get_option() for a starter which is provided by cmdline.c. > > > > ... > > > > lib/cmdline_kunit.c | 98 +++++++++++++++++++++++++++++++++++++++++++++ First of all, thanks for taking care of this! > The spectacular warning storm which this produces makes me wonder if > you sent the correct version? I mean, the cmdline_test_values[] > definition wasn't even close. This now puzzles me, what happened. I will check my branches, because certainly I was not only compiled that, but actually run those test cases. There is warning about license, I'm going to address right now. -- With Best Regards, Andy Shevchenko