David Gow <davidgow@xxxxxxxxxx> writes: > diff --git a/fs/fat/Kconfig b/fs/fat/Kconfig > index 66532a71e8fd..4e66f7e8defc 100644 > --- a/fs/fat/Kconfig > +++ b/fs/fat/Kconfig > @@ -115,3 +115,15 @@ config FAT_DEFAULT_UTF8 > Say Y if you use UTF-8 encoding for file names, N otherwise. > > See <file:Documentation/filesystems/vfat.rst> for more information. > + > +config FAT_KUNIT_TEST > + tristate "Unit Tests for FAT filesystems" if !KUNIT_ALL_TESTS > + depends on KUNIT && (MSDOS_FS || VFAT_FS) > + default KUNIT_ALL_TESTS > + help > + This builds the FAT KUnit tests > + > + For more information on KUnit and unit tests in general, please refer > + to the KUnit documentation in Documentation/dev-tools/kunit > + > + If unsure, say N Maybe, the following would be better? With this, it looks like kunit works whether depends on or select. Thanks. diff --git a/fs/fat/Kconfig b/fs/fat/Kconfig index ca31993..c1229d4 100644 --- a/fs/fat/Kconfig 2020-09-02 20:48:54.967175266 +0900 +++ b/fs/fat/Kconfig 2020-10-24 16:44:07.734324397 +0900 @@ -77,7 +77,7 @@ config VFAT_FS config FAT_DEFAULT_CODEPAGE int "Default codepage for FAT" - depends on MSDOS_FS || VFAT_FS + depends on FAT_FS default 437 help This option should be set to the codepage of your FAT filesystems. @@ -115,3 +115,15 @@ config FAT_DEFAULT_UTF8 Say Y if you use UTF-8 encoding for file names, N otherwise. See <file:Documentation/filesystems/vfat.rst> for more information. + +config FAT_KUNIT_TEST + tristate "Unit Tests for FAT filesystems" if !KUNIT_ALL_TESTS + depends on KUNIT && FAT_FS + default KUNIT_ALL_TESTS + help + This builds the FAT KUnit tests + + For more information on KUnit and unit tests in general, please refer + to the KUnit documentation in Documentation/dev-tools/kunit + + If unsure, say N _ -- OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
