Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-08-27, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Aug 26, 2020 at 02:48:19PM -0600, Ross Zwisler wrote:
> 
> > Al, now that the changes to fs/namei.c have landed and we're past the merge
> > window for v5.9, what are your thoughts on this patch and the associated test?
> 
> Humm...  should that be nd->path.mnt->mnt_flags or link->mnt->mnt_flags?
> Usually it's the same thing, but they might differ.  IOW, is that about the
> directory we'd found it in, or is it about the link itself?

Now that you mention it, I think link->mnt->mnt_flags makes more sense.
The restriction should apply in the context of whatever filesystem
contains the symlink, and that would matches FreeBSD's semantics (at
least as far as I can tell from a quick look at sys/kern/vfs_lookup.c).

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux