On Wed, Jul 29, 2020 at 12:19 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 29, 2020 at 04:11:51PM -0300, Vitor Massaru Iha wrote: > > This adds the conversion of the test_sort.c to KUnit test. > > > > Please apply this commit first (linux-kselftest/kunit-fixes): > > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space > > Looks like you mixed up commit message and changelog / comments. > > > Code Style Documentation: [0] > > > > Fix these warnings Reported-by lkp@xxxxxxxxx > > > > WARNING: modpost: vmlinux.o(.data+0x4fc70): Section mismatch in reference from the variable sort_test_cases to the variable .init.text:sort_test > > The variable sort_test_cases references > > the variable __init sort_test > > If the reference is valid then annotate the > > variable with or __refdata (see linux/init.h) or name the variable > > > > WARNING: modpost: lib/sort_kunit.o(.data+0x11c): Section mismatch in reference from the variable sort_test_cases to the function .init.text:sort_test() > > The variable sort_test_cases references > > the function __init sort_test() > > > Signed-off-by: Vitor Massaru Iha <vitor@xxxxxxxxxxx> > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Link: [0] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@xxxxxxxxxx/T/#u > > This should be in different order: Link, Reported-by, SoB. > Also [0] is unnecessary > > > lib/{test_sort.c => sort_kunit.c} | 31 +++++++++++++++---------------- > > Still opened question why kunit is a suffix? Can't we leave same name? Can't we > do it rather prefix? Sorry to jump in now; I thought Vitor's reply with a link to the new proposed documentation[1] addressed this. The naming convention issue came up about a month ago[2]. The people in the discussion (including myself) came to an agreement on _kunit.c. That being said, the documentation hasn't been accepted yet, so if you really feel strongly about it, now is the time to change it. All that being said, I would rather not discuss that issue here for the benefit of the participants in the preceding discussions. I posted lore links for the relevant threads, which should be easy enough to In-Reply-To your way into. Nevertheless, if it makes it easier, let me know and I can CC you into the discussions. [1] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@xxxxxxxxxx/T/#u [2] https://lore.kernel.org/linux-kselftest/202006141005.BA19A9D3@keescook/t/#u Cheers
