On Tue, Jun 23, 2020 at 04:32:12PM -0700, Randy Dunlap wrote: > On 6/23/20 4:10 PM, Kees Cook wrote: > > On Fri, May 29, 2020 at 01:03:43PM -0700, Kees Cook wrote: > >> Hi Greg, > >> > >> Can you please apply these patches to your drivers/misc tree for LKDTM? > >> It's mostly a collection of fixes and improvements and tweaks to the > >> selftest integration. > > > > Friendly ping -- we're past -rc2 now. :) > > > > Thanks! > > > > -Kees > > > >> > >> Thanks! > >> > >> -Kees > >> > >> Kees Cook (4): > >> lkdtm: Avoid more compiler optimizations for bad writes > >> lkdtm/heap: Avoid edge and middle of slabs > >> selftests/lkdtm: Reset WARN_ONCE to avoid false negatives > >> lkdtm: Make arch-specific tests always available > >> > >> drivers/misc/lkdtm/bugs.c | 45 +++++++++++++------------ > >> drivers/misc/lkdtm/heap.c | 9 ++--- > >> drivers/misc/lkdtm/lkdtm.h | 2 -- > >> drivers/misc/lkdtm/perms.c | 22 ++++++++---- > >> drivers/misc/lkdtm/usercopy.c | 7 ++-- > >> tools/testing/selftests/lkdtm/run.sh | 6 ++++ > >> tools/testing/selftests/lkdtm/tests.txt | 1 + > >> 7 files changed, 56 insertions(+), 36 deletions(-) > >> > >> -- > >> 2.25.1 > >> > > > > >> Regardless, it seems arch/x86/um/asm/desc.h is not needed any more? > > > True that, we can rip the file. > > Has anyone fixed the uml build errors? Oh, I thought that had nothing to do with the lkdtm changes? Should I rip out that file and resend? -- Kees Cook