On Fri, Jun 12, 2020 at 08:19:00PM +0200, Christian Brauner wrote: > On Thu, Jun 11, 2020 at 03:40:24PM -0700, Kees Cook wrote: > > The binderfs test mixed the full harness API and the selftest API. > > Adjust to use only the harness API so that the harness API can switch > > to using the selftest API internally in future patches. > > > > Cc: Shuah Khan <shuah@xxxxxxxxxx> > > Cc: Christian Brauner <christian.brauner@xxxxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Cc: linux-kselftest@xxxxxxxxxxxxxxx > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> > > --- > > I had this on my TODO but never actually got around to it, so thanks! > > In all honesty, I've done a "Does this overall look sane?" review. > Simply because I lack the time to do this in more detail right now but > I'm happy this work is done and so overall: > > Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx> I did actually do runtime tests of this (and found a couple bugs in my port that I fixed before sending the final version). So, fwiw, it passes for me. Thanks for the review! -Kees -- Kees Cook
