On Mon, Jun 08, 2020 at 10:02:04AM +0000, Amit Cohen wrote: > Andrew Lunn <andrew@xxxxxxx> writes: > > >> +Link extended states: > >> + > >> + ============================ ============================================= > >> + ``Autoneg failure`` Failure during auto negotiation mechanism > > > >I think you need to define 'failure' here. > > > >Linux PHYs don't have this state. auto-neg is either ongoing, or has completed. There is no time limit for auto-neg. If there is no link partner, auto-neg does not fail, it just continues until there is a link partner which responds and negotiation completes. > > > >Looking at the state diagrams in 802.3 clause 28, what do you consider as failure? > > > > Ok, you're right. What about renaming this state to "Autoneg issue" and then as ext_substate you can use something like "Autoneg ongoing"? Hi Amit I'm not sure 'issue' is correct here. Just because it has not completed does not mean there is an issue. It takes around 1.5 seconds anyway, best case. And if there is no link partner, it is not supposed to complete. So i would suggest just ``Autoneg``. Andrew
