Re: [PATCH] selftests/seccomp: use 90s as timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 01, 2020 at 09:32:02AM -0300, Thadeu Lima de Souza Cascardo wrote:
> As seccomp_benchmark tries to calibrate how many samples will take more
> than 5 seconds to execute, it may end up picking up a number of samples
> that take 10 (but up to 12) seconds. As the calibration will take double
> that time, it takes around 20 seconds. Then, it executes the whole thing
> again, and then once more, with some added overhead. So, the thing might
> take more than 40 seconds, which is too close to the 45s timeout.
> 
> That is very dependent on the system where it's executed, so may not be
> observed always, but it has been observed on x86 VMs. Using a 90s timeout
> seems safe enough.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxx>

Excellent point! Thanks, I've applied this (well, actually, your v2)
to for-next/seccomp.

-- 
Kees Cook



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux