Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/22/20 9:12 AM, Mark Brown wrote:
On Fri, May 22, 2020 at 08:55:50AM -0600, shuah wrote:
On 5/19/20 11:44 AM, Mark Brown wrote:

WARNING: Missing a blank line after declarations
WARNING: Missing a blank line after declarations
#135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27:
+	unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);

A blank line after declarations here just like what checkpatch
suggests. It makes it readable.

That doesn't match the idiom used by any of the surrounding code :(


I can't parse the idiom statement? Can you clarify it please.

thanks,
-- Shuah



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux