Hi Sai, On 5/18/2020 3:08 PM, Sai Praneeth Prakhya wrote: > Fenghua Yu (1): > selftests/resctrl: Fix missing options "-n" and "-p" > > Reinette Chatre (3): > selftests/resctrl: Fix typo > selftests/resctrl: Fix typo in help text > selftests/resctrl: Ensure sibling CPU is not same as original CPU > > Sai Praneeth Prakhya (15): > selftests/resctrl: Rename CQM test as CMT test > selftests/resctrl: Declare global variables as extern > selftests/resctrl: Return if resctrl file system is not supported > selftests/resctrl: Check for resctrl mount point only if resctrl FS is > supported > selftests/resctrl: Use resctrl/info for feature detection > selftests/resctrl: Fix MBA/MBM results reporting format > selftests/resctrl: Abort running tests if not root user > selftests/resctrl: Enable gcc checks to detect buffer overflows > selftests/resctrl: Dynamically select buffer size for CAT test > selftests/resctrl: Skip the test if requested resctrl feature is not > supported > selftests/resctrl: Change return type of umount_resctrlfs() to void > selftests/resctrl: Umount resctrl FS only if mounted > selftests/resctrl: Unmount resctrl FS after running all tests > selftests/resctrl: Fix incorrect parsing of iMC counters > selftests/resctrl: Fix checking for < 0 for unsigned values > > tools/testing/selftests/resctrl/Makefile | 2 +- > tools/testing/selftests/resctrl/README | 4 +- > tools/testing/selftests/resctrl/cache.c | 4 +- > tools/testing/selftests/resctrl/cat_test.c | 8 +- > .../resctrl/{cqm_test.c => cmt_test.c} | 23 +++--- > tools/testing/selftests/resctrl/mba_test.c | 23 +++--- > tools/testing/selftests/resctrl/mbm_test.c | 16 ++-- > tools/testing/selftests/resctrl/resctrl.h | 20 +++-- > .../testing/selftests/resctrl/resctrl_tests.c | 69 ++++++++++++----- > tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++------ > tools/testing/selftests/resctrl/resctrlfs.c | 77 +++++++++++++------ > 11 files changed, 195 insertions(+), 118 deletions(-) > rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (88%) > Thank you very much for creating these fixes. There are a few to which I responded directly, the rest look good to me. Reinette