Re: [PATCH V2 15/19] selftests/resctrl: Change return type of umount_resctrlfs() to void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sai,

On 5/18/2020 3:08 PM, Sai Praneeth Prakhya wrote:
> umount_resctrlfs() is used only during tear down path and there is nothing
> much to do if unmount of resctrl file system fails, so, all the callers of
> this function are not checking for the return value. Hence, change the
> return type of this function from int to void.

Should the callers be ignoring the return value? From what I can tell
the filesystem is unmounted between test runs so I wonder if it may help
if the return code is used and the test exits with an appropriate error
to user space for possible investigation instead of attempting to run a
new test on top of the resctrl filesystem that could potentially be
having issues at the time.

Reinette



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux