On Wed 13 May 2020 at 21:35, Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote: > On Wed, May 13, 2020 at 10:58 AM Vlad Buslov <vladbu@xxxxxxxxxxxx> wrote: >> >> Flower tests used to create ingress filter with specified parent qdisc >> "parent ffff:" but dump them on "ingress". With recent commit that fixed >> tcm_parent handling in dump those are not considered same parent anymore, >> which causes iproute2 tc to emit additional "parent ffff:" in first line of >> filter dump output. The change in output causes filter match in tests to >> fail. > > My commit simply restores the old behavior prior to 4.15, so are you > saying these tests never work correctly on kernels <= 4.15? If so, > they must be fixed no matter of my commit, right? > > Thanks. I think all of these tests are newer than 4.15.