On Thu, 7 May 2020 15:32:46 -0500 "Zanussi, Tom" <tom.zanussi@xxxxxxxxxxxxxxx> wrote: > Hi, > > On 5/7/2020 12:25 PM, Steven Rostedt wrote: > > On Fri, 8 May 2020 00:50:28 +0900 > > Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote: > > > >>>> Yes, I need Tom's review for this change. As far as I can test, this > >>>> fixes the test failure. If this isn't acceptable, we can use "alias echo=echo" > >>>> for this test case. > >>>> > >>> > >>> I still don't see how changing "keys=common_pid" to "keys=ip" has anything > >>> to do with the echo patch. If that is a problem, it should be a different > >>> patch with explanation to why "keys=common_pid" is broken. > >> > >> This test case uses a trace_marker event to make a histogram with > >> the common_pid key, and it expects the "echo" command is built-in command > >> so that the pid is same while writing several events to trace_marker. > >> I changed it to "ip" which is always same if trace_marker interface is > >> used. > > > > Can you explicitly state that in your change log? It wasn't obvious from > > what you meant with: > > > > "This also fixes some test cases which expects built-in echo command." OK, will add the description. > > > > With that change, > > Reviewed-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> Thanks Tom! > > Thanks, > > Tom > > > Thanks! > > > > -- Steve > > -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
