On Tue, Apr 14, 2020 at 3:13 PM Lothar Rubusch <l.rubusch@xxxxxxxxx> wrote: > > Fix warnings at 'make htmldocs', and formatting issues in the resulting > documentation. > > - test.h: Fix annotation in kernel-doc parameter description. > > - Documentation/*.rst: Fixing formatting issues, and a duplicate label > issue due to usage of sphinx.ext.autosectionlabel and identical labels > within one document (sphinx warning) > > NB: checkpatch.pl will complain about flow control statements (i.e. usage > of "return") within the macro kunit_test_suites(suites_list...). > > v2: Several documentation fixes > > v3: Do not touch API documentation index > > v4: Replace macro argument in test.h by named variadic argument nit: Sorry for not pointing this out before, but comments like this (previous revisions, notes to reviewers but not future readers, etc) should go below between the '---' and the list of changed files. I called the comment area out below for your benefit. > Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx> One minor nit, other than that: Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > --- <Comments go here> > Documentation/dev-tools/kunit/start.rst | 13 ++++++++----- > Documentation/dev-tools/kunit/usage.rst | 4 ++-- > include/kunit/test.h | 12 ++++++------ > 3 files changed, 16 insertions(+), 13 deletions(-)