----- On Mar 26, 2020, at 11:49 AM, Palmer Dabbelt palmer@xxxxxxxxxxx wrote:
> On Sun, 08 Mar 2020 22:59:52 PDT (-0700), vincent.chen@xxxxxxxxxx wrote:
>> Add support for risc-v in the rseq selftests, which covers both
>> 64-bit and 32-bit ISA with little endian mode.
>>
>> Signed-off-by: Vincent Chen <vincent.chen@xxxxxxxxxx>
>> ---
>> tools/testing/selftests/rseq/param_test.c | 23 ++
>> tools/testing/selftests/rseq/rseq-riscv.h | 622 ++++++++++++++++++++++++++++++
>> tools/testing/selftests/rseq/rseq.h | 2 +
>> 3 files changed, 647 insertions(+)
>> create mode 100644 tools/testing/selftests/rseq/rseq-riscv.h
>
> There are a ton of checkpatch errors in here.
Is it just my mail client or the main issue is:
ERROR: DOS line endings
?
As far as other issues are concerned, I know there are a few checkpatch
false-positives that trigger for my rseq-{$ARCH}.h header, from which rseq-riscv.h
is derived, because it has issues with extensive use of inline assembly.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
