On Wed, 18 Mar 2020 10:35:29 -0600 Shuah Khan <shuahkhan@xxxxxxxxx> wrote: > On Wed, Mar 18, 2020 at 9:13 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > > > From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx> > > > > The ftrace selftest "ftrace - test for function traceon/off triggers" > > enables all events and reads the trace file. Now that the trace file does > > not disable tracing, and will attempt to continually read new data that is > > added, the selftest gets stuck reading the trace file. This is because the > > data added to the trace file will fill up quicker than the reading of it. > > > > By only enabling scheduling events, the read can keep up with the writes. > > Instead of enabling all events, only enable the scheduler events. > > > > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> Looks good to me. Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx> Thanks! > > --- > > .../selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > + linux-kselttest and my LF email. > > thanks, > -- Shuah -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
