On Wed, Mar 4, 2020 at 3:07 AM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote: > > Introduce KUNIT_INDENT macro which corresponds to 4-space indentation, > and use it to modify indentation from tab to 4 spaces. > > Suggested-by: Frank Rowand <frowand.list@xxxxxxxxx> > Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx> Sorry for the late comment. This change looks good except for one thing: kunit_tool (tools/testing/kunit/kunit.py) expects the wrong indentation. Can you fix it? I think it would be best to fix it in this change so that there is point at which it is broken. Currently, this change breaks it. For example, with CONFIG_KUNIT_TEST=y and CONFIG_KUNIT_EXAMPLE_TEST=y. kunit_tool reports the following: Testing complete. 0 tests run. 0 failed. 0 crashed. I am pretty sure the change needs to happen in tools/testing/kunit/kunit_parser.py. Cheers
