Hi Sai, On 3/9/2020 3:22 PM, Prakhya, Sai Praneeth wrote: > Hi Reinette, > >> -----Original Message----- >> From: Reinette Chatre <reinette.chatre@xxxxxxxxx> >> Sent: Monday, March 9, 2020 2:45 PM >> On 3/6/2020 7:40 PM, Sai Praneeth Prakhya wrote: [SNIP] >> Please note that this is only a partial fix. The current feature detection relies on >> the feature flags found in /proc/cpuinfo. Quirks and kernel boot parameters are >> not taken into account. This fix only addresses the parsing of feature flags. If a >> feature has been disabled via kernel boot parameter or quirk then the resctrl >> tests would still attempt to run the test for it. > > That's a good point and makes sense to me. I think we could fix it in two ways > 1. grep for strings in dmesg but that will still leave ambiguity in deciding b/w mbm and cqm because kernel prints "resctrl: L3 monitoring detected" for both the features > 2. Check in "info" directory > a. For cat_l3, we could search for info/L3 > b. For mba, we could search for info/MB > c. For cqm and mbm, we could search for specified string in info/L3_MON/mon_features > > I think option 2 might be better because it can handle all cases, please let me know what you think. I agree. For the reasons you mention and also that (1) may not be possible if the loglevel prevents those lines from being printed. Reinette
