> -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx] > Sent: Tuesday, March 3, 2020 4:54 PM > To: Zhoujian (jay) <jianjay.zhou@xxxxxxxxxx>; kvm@xxxxxxxxxxxxxxx > Cc: peterx@xxxxxxxxxx; shuah@xxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; wangxin (U) <wangxinxin.wang@xxxxxxxxxx>; > Huangweidong (C) <weidong.huang@xxxxxxxxxx>; Liujinsong (Paul) > <liu.jinsong@xxxxxxxxxx> > Subject: Re: [PATCH] kvm: selftests: Support dirty log initial-all-set test > > On 03/03/20 09:07, Jay Zhou wrote: > > #ifdef USE_CLEAR_DIRTY_LOG > > - if (!kvm_check_cap(KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2)) { > > - fprintf(stderr, "KVM_CLEAR_DIRTY_LOG not available, skipping > tests\n"); > > + dirty_log_manual_caps = > > + kvm_check_cap(KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2); > > + if (!dirty_log_manual_caps) { > > + fprintf(stderr, "KVM_CLEAR_DIRTY_LOG not available, " > > + "skipping tests\n"); > > + exit(KSFT_SKIP); > > + } > > + if (dirty_log_manual_caps != KVM_DIRTY_LOG_MANUAL_CAPS && > > + dirty_log_manual_caps != > KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE) { > > + fprintf(stderr, "KVM_CLEAR_DIRTY_LOG not valid caps " > > + "%"PRIu64", skipping tests\n", > > + dirty_log_manual_caps); > > exit(KSFT_SKIP); > > } > > #endif > > > > Thanks, instead of this final "if" it should be enough to do > > dirty_log_manual_caps &= (KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE > | > KVM_DIRTY_LOG_INITIALLY_SET); > > > Otherwise looks good, I'll test it and eventually apply both patches. Do I need to resubmit this patch with this modification? Regards, Jay Zhou > > Paolo
