Re: [PATCH bpf-next v2 3/5] bpftool: Update documentation of "bpftool feature" command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2020-02-21 04:16 UTC+0100 ~ Michal Rostecki <mrostecki@xxxxxxxxxxxx>
Update documentation of "bpftool feature" command with information about
new arguments: "full".

Signed-off-by: Michal Rostecki <mrostecki@xxxxxxxxxxxx>
---
  .../bpf/bpftool/Documentation/bpftool-feature.rst | 15 ++++++++++-----
  1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/tools/bpf/bpftool/Documentation/bpftool-feature.rst b/tools/bpf/bpftool/Documentation/bpftool-feature.rst
index 4d08f35034a2..2e8f66ee1e77 100644
--- a/tools/bpf/bpftool/Documentation/bpftool-feature.rst
+++ b/tools/bpf/bpftool/Documentation/bpftool-feature.rst
@@ -19,19 +19,24 @@ SYNOPSIS
  FEATURE COMMANDS
  ================
-| **bpftool** **feature probe** [*COMPONENT*] [**macros** [**prefix** *PREFIX*]]
+|	**bpftool** **feature probe** [*COMPONENT*] [**full**] [**macros** [**prefix** *PREFIX*]]
  |	**bpftool** **feature help**
  |
  |	*COMPONENT* := { **kernel** | **dev** *NAME* }
DESCRIPTION
  ===========
-	**bpftool feature probe** [**kernel**] [**macros** [**prefix** *PREFIX*]]
+	**bpftool feature probe** [**kernel**] [**full**] [**macros** [**prefix** *PREFIX*]]
  		  Probe the running kernel and dump a number of eBPF-related
  		  parameters, such as availability of the **bpf()** system call,
  		  JIT status, eBPF program types availability, eBPF helper
  		  functions availability, and more.
+ By default, bpftool does not run probes for
+		  bpf_probe_write_user and bpf_trace_printk helpers which emit

Please use formatting on helper function names, for readability and consistency.

I would even be tempted to highlight part or all of the sentence, with caps or bold, as some users may be surprised not to see those helpers in the list of available helpers on their system.

+		  dmesg warnings. To enable them and run all probes, the
+		  **full** keyword should be used.
+
  		  If the **macros** keyword (but not the **-j** option) is
  		  passed, a subset of the output is dumped as a list of
  		  **#define** macros that are ready to be included in a C
@@ -48,12 +53,12 @@ DESCRIPTION
  		  **bpf_trace_printk**\ () or **bpf_probe_write_user**\ ()) may
  		  print warnings to kernel logs.

This should maybe be moved upwards and combined with your new paragraph?

- **bpftool feature probe dev** *NAME* [**macros** [**prefix** *PREFIX*]]
+	**bpftool feature probe dev** *NAME* [**full**] [**macros** [**prefix** *PREFIX*]]
  		  Probe network device for supported eBPF features and dump
  		  results to the console.
- The two keywords **macros** and **prefix** have the same
-		  role as when probing the kernel.
+		  The keywords **full**, **macros** and **prefix** have the
+		  same role as when probing the kernel.
**bpftool feature help**
  		  Print short help message.





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux