On Wed, 15 Jan 2020 15:12:56 +0100
Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote:
> From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
>
> Fix all files in samples/bpf to include libbpf header files with the bpf/
> prefix, to be consistent with external users of the library. Also ensure
> that all includes of exported libbpf header files (those that are exported
> on 'make install' of the library) use bracketed includes instead of quoted.
>
> To make sure no new files are introduced that doesn't include the bpf/
> prefix in its include, remove tools/lib/bpf from the include path entirely,
> and use tools/lib instead.
>
> Fixes: 6910d7d3867a ("selftests/bpf: Ensure bpf_helper_defs.h are taken from selftests dir")
> Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
I like this change. Maybe the reason so many samples/bpf/ files
still included "libbpf.h" was that once-upon-a-time we had a "eBPF mini
library" in the file samples/bpf/libbpf.h that were included.
The file was removed/renamed in:
https://git.kernel.org/torvalds/c/8d93045077ae
Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
