On Mon, Dec 02, 2019 at 12:42:20PM +0100, SeongJae Park wrote: > From: SeongJae Park <sjpark@xxxxxxxxx> > > If a timeout failure occurs, kselftest kills the test process and prints > the timeout log. If the test process has killed while printing a log > that ends with new line, the timeout log can be printed in middle of the > test process output so that it can be seems like a comment, as below: > > # test_process_log not ok 3 selftests: timers: nsleep-lat # TIMEOUT > > This commit avoids such problem by printing one more line before the > TIMEOUT failure log. > > Signed-off-by: SeongJae Park <sjpark@xxxxxxxxx> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> Cool, yeah, this looks fine to me. Nice idea! -Kees > --- > tools/testing/selftests/kselftest/runner.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh > index 84de7bc74f2c..a8d20cbb711c 100644 > --- a/tools/testing/selftests/kselftest/runner.sh > +++ b/tools/testing/selftests/kselftest/runner.sh > @@ -79,6 +79,7 @@ run_one() > if [ $rc -eq $skip_rc ]; then \ > echo "not ok $test_num $TEST_HDR_MSG # SKIP" > elif [ $rc -eq $timeout_rc ]; then \ > + echo "#" > echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT" > else > echo "not ok $test_num $TEST_HDR_MSG # exit=$rc" > -- > 2.17.1 > -- Kees Cook
