On 11/26/19 4:31 PM, Masami Hiramatsu wrote:
On Tue, 26 Nov 2019 12:49:01 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
On Tue, 26 Nov 2019 17:34:24 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
@@ -15,6 +15,11 @@ if [ $NP -eq 1 ] ;then
exit_unresolved
fi
+if ! grep -q function available_tracers ; then
+ echo "Function trace is not enabled"
+ exit_unsupported
+fi
+
ORIG_CPUMASK=`cat tracing_cpumask`
Strange, but the bashism test failed:
++ checkbashisms /work/git-local/linux.git/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
possible bashism in /work/git-local/linux.git/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc line 18 ('function' is useless):
if ! grep -q function available_tracers ; then
Not sure why it did not like that line. Maybe my bashism check got
confused by the key word "function"?
Yep!
By adding quotes around "function" it doesn't complain:
if ! grep -q "function" available_tracers ; then
May need to add that.
Thanks! Shuah, can I update this patch?
I'll send it asap.
Thank you,
No worries. Take your time. I won't pull in until things settle down.
I noticed Steve gave you review comments.
thanks,
-- Shuah
