On Tue, 26 Nov 2019 09:13:45 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> > > @@ -93,7 +96,6 @@ initialize_ftrace() { # Reset ftrace to initial-state
> > > disable_events
> > > [ -f set_event_pid ] && echo > set_event_pid
> > > [ -f set_ftrace_pid ] && echo > set_ftrace_pid
> > > - [ -f set_ftrace_filter ] && echo | tee set_ftrace_*
> >
> > The above should be changed to:
> >
> > [ -f set_ftrace_notrace ] && echo > set_ftrace_notrace
>
> Ah, good point! I think that should be done by another patch, since
> it will improve ftracetest.
No, it belongs in this patch, because you are removing:
[ -f set_ftrace_filter ] && echo | tee set_ftrace_*
which is equivalent to:
[ -f set_ftrace_filter ] && echo > set_ftrace_filter
[ -f set_ftrace_filter ] && echo > set_ftrace_notrace
as the "tee set_ftrace_*" covers both.
Without this change, this patch removes the update to
set_ftrace_notrace.
-- Steve
