On Thu, Nov 21, 2019 at 12:41:45PM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 21, 2019 at 12:39:25PM +0200, Jarkko Sakkinen wrote: > > > +void init_feature_control_msr(struct cpuinfo_x86 *c) > > I'd also use here shorter init_feat_ctl_msr(). It has one call site > but shorter name is more convenient when playing with tracing tools. Yeah, and since we're shortening all to feat_ctl, let's do: mv arch/x86/kernel/cpu/feature_control.c arch/x86/kernel/cpu/feat_ctl.c too. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette