On Mon, Nov 18, 2019 at 07:12:22PM -0800, Sean Christopherson wrote: > As pointed out by Boris, the defines for bits in IA32_FEATURE_CONTROL > are quite a mouthful, especially the VMX bits which must differentiate > between enabling VMX inside and outside SMX (TXT) operation. Rename the > bit defines to abbreviate FEATURE_CONTROL as FEAT_CTL so that they're a > little friendlier on the eyes. Keep the full name for the MSR itself to > help even the most obtuse reader decipher the abbreviation, and to match > the name used by the Intel SDM. If you anyway shorten the prefix, why not then go directly to FT_CTL? It is as obvious as FEAT_CTL is. Given the exhausting long variable names like FEAT_CTL_VMX_ENABLED_OUTSIDE_SMX this would be worth of considering. /Jarkko
